Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Qualify Plugin use in register_plugin! macro #2

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: Qualify Plugin use in register_plugin! macro #2

merged 1 commit into from
Oct 23, 2023

Conversation

matheus23
Copy link
Member

I didn't test this yet. I literally edited this in the github interface 😅 (after locally noticing that the macro wouldn't work without an import).

Just noticed that there was another identifier that's probably better qualified in the macro.

✌️

@matheus23 matheus23 self-assigned this Oct 11, 2023
@matheus23 matheus23 requested a review from QuinnWilton October 16, 2023 19:11
QuinnWilton
QuinnWilton approved these changes Oct 23, 2023
View reviewed changes
Copy link

@QuinnWilton QuinnWilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@QuinnWilton QuinnWilton merged commit 16e5565 into quinn-wip-rework Oct 23, 2023
@matheus23 matheus23 deleted the matheus23/qualfy-plugin-macro branch October 23, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuinnWilton QuinnWilton QuinnWilton approved these changes

Assignees

@matheus23 matheus23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheus23 @QuinnWilton